Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12, retire Python 3.7 #291

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

vonschultz
Copy link
Contributor

Is the PR a fix or a feature?
Python version upgrade.

Describe the changes in the PR

Assuming we want to support four active Python versions, retire Python 3.7, which is end-of-life since nearly a year ago, and add support for Python 3.12.

New Python versions are released once a year, and make for a good reason to make a release to PyPI, even if there haven't been any major changes to the code base. Not making a release for a year results in warnings such as "An important project maintenance signal to consider for sphobjinv is that it hasn't seen any new versions released to PyPI in the past 12 months, and could be considered as a discontinued project, or that which receives low attention from its maintainers" on https://snyk.io/advisor/python/sphobjinv, which companies use to determine if a project is an acceptable dependency.

Does this PR close any issues?

No.

Does the PR change/update the following, if relevant?

  • Documentation
  • Tests
  • CHANGELOG

Assuming we want to support four active Python versions, retire Python
3.7, which is end-of-life since nearly a year ago, and add support for
Python 3.12.

New Python versions are released once a year, and make for a good
reason to make a release to PyPI, even if there haven't been any major
changes to the code base. Not making a release for a year results in
warnings such as "An important project maintenance signal to consider
for sphobjinv is that it hasn't seen any new versions released to PyPI
in the past 12 months, and could be considered as a discontinued
project, or that which receives low attention from its maintainers" on
https://snyk.io/advisor/python/sphobjinv, which companies use to
determine if a project is an acceptable dependency.
@bskinn
Copy link
Owner

bskinn commented May 8, 2024

New Python versions are released once a year, and make for a good reason to make a release to PyPI, even if there haven't been any major changes to the code base.

Agreed, I've been meaning to make a release with these bumps for a while but haven't had a chance. Thanks for putting this together! I had it in mind to implement #283 as part of a v2.3.2 that included a Python versions bump like this, but I should probably just do a maintenance release to get it out there.

I already have that linting error addressed in another branch. Once that goes into main and this PR branch is updated, it should resolve.

bskinn
bskinn previously requested changes May 10, 2024
Copy link
Owner

@bskinn bskinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change to python_requires, if you would.

setup.cfg Show resolved Hide resolved
@bskinn
Copy link
Owner

bskinn commented May 10, 2024

Ok, @vonschultz, I've merged the PR with the fix to the flake8 config. Go ahead and update your branch against main, and we'll see how the CI does. You'll probably have to resolve a merge conflict on the CHANGELOG, unfortunately.

@bskinn bskinn dismissed their stale review May 13, 2024 03:45

After discussion, no change is required

@bskinn bskinn merged commit 3ab0989 into bskinn:main May 14, 2024
26 checks passed
@bskinn
Copy link
Owner

bskinn commented May 14, 2024

Thanks for this, @vonschultz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants