-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wake on Lan #199
Open
codetheweb
wants to merge
5
commits into
bschlenk:master
Choose a base branch
from
codetheweb:feature/wake-on-lan
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wake on Lan #199
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a38447a
feat: basic WoL implementation
codetheweb bb1fbed
chore: update documentation
codetheweb 5bb8eb9
fix: use requestTimeout parameter for pTimeout
codetheweb b333242
fix: remove duplicate check
codetheweb 9ea294a
fix: add note to README about WoL
codetheweb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this again, will this ever work as expected? If the TV is off, this will fail immediately and never trigger the TimeoutError check below. I don't think we even need to use pTimeout at all. We can always try sending the WOL packet if this initially fails. Then you'd have to retry
this.roku.info()
to see if it actually turned on (the retry would need to be done after some timeout to give it time to turn on), then if it still isn't on, you call callback with the error, otherwise with null.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been working for me so far 😛.
Nope,
this.roku.info()
doesn't resolve until around 10 seconds later if the TV is offline; node-fetch which is used by the Roku package sorta has timeout support but I don't think the Roku package implements it.