Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clickhouse.py #85

Closed
wants to merge 2 commits into from
Closed

Update clickhouse.py #85

wants to merge 2 commits into from

Conversation

amolsr
Copy link

@amolsr amolsr commented May 30, 2024 •
edited
Loading

Added get_pandas_df method.

@amolsr amolsr mentioned this pull request May 30, 2024
Closed
@bryzgaloff
Copy link
Owner

Hi @amolsr and thank you for a proposal. get_pandas_df is not required as a core functionality for the plugin, so I may not accept this contribution. Such a feature must be introduced as a separate mixin which can be also wrapped into a separate Airflow plugin and be reusable with other plugins too. It must not be coded into ClickHouse plugin itself since it is not a CH-specific functionality.

@bryzgaloff bryzgaloff closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amolsr @bryzgaloff