Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Airflow 2.8.0 #73

Merged
merged 2 commits into from
Jan 30, 2024
Merged

support Airflow 2.8.0 #73

merged 2 commits into from
Jan 30, 2024

Conversation

bobelev
Copy link
Contributor

@bobelev bobelev commented Dec 21, 2023

Airflow 2.8.0 has been released https://github.com/apache/airflow/releases/tag/2.8.0

Let's make this plugin compatible

@simpl1g
Copy link

simpl1g commented Jan 29, 2024

@bryzgaloff Hi, is it possible to review this PR? Would be great to bump version and update airflow version 😃

@bryzgaloff
Copy link
Owner

Hi guys, thank you for bringing the PR up. As you may have noticed, it did not pass some tests, so I was not able to merge it.

However, the tests were failing due to some versions inconsistencies in the packages installed during the tests execution. I have fixed it in #74. That PR is now merge, so please rebase yours onto the latest master: it will apply the versions fix and all the older tests should be passing after that.

Copy link
Owner

@bryzgaloff bryzgaloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good, just requires a rebase to make sure all the tests are passing

.github/workflows/tests.yml Outdated Show resolved Hide resolved
yandex/clickhouse-server has been deprecated a while ago
@bobelev
Copy link
Contributor Author

bobelev commented Jan 30, 2024

Hi! Rebased, all green.

@bryzgaloff bryzgaloff merged commit d3404cf into bryzgaloff:master Jan 30, 2024
84 checks passed
@bryzgaloff
Copy link
Owner

bryzgaloff commented Jan 30, 2024

Thank you for your valuable contribution! 👏 I have added you to the contributors list in README.

Release v1.2.0 is being published: https://github.com/bryzgaloff/airflow-clickhouse-plugin/releases/tag/v1.2.0

CC @simpl1g

@bryzgaloff
Copy link
Owner

Unfortunately, there was an issue publishing the pipeline, so the latest release is not yet available: #75

I am on it, some time is needed to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants