specify the forward progress guarantee made by run_loop's run member function #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericniebler
commented
Jan 19, 2023
| @@ -6841,6 +6841,8 @@ enum class forward_progress_guarantee { | |||
|
|
|||
| 2. <i>Synchronization:</i> This operation synchronizes with all `pop_front` operations on this object. | |||
|
|
|||
| 3. <i>Remarks:</i> If the thread of execution calling `run()` guarantees concurrent or parallel forward progress, then it guarantees parallel forward progress until `run()` returns; otherwise, it guarantees weakly parallel forward progress. | |||
|
|
|||
There was a problem hiding this comment.
From this comment:
<sigh> I've gotten myself confused again. Since the execution of
run()involves blocking for some condition to be satisfied by another thread (work is added to the queue, or another thread callsfinish()), and since we can't guarantee that that will ever happen, it's possible thatrun()will never make progress. So doesn't that mean that the thread of execution callingrun()has weakly parallel FP until it returns?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.