Added support for RTSP #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: e1z0 github.com/e1z0
|
please @brutella, review this |
|
: ( |
|
Sorry for not looking into this so far. Your pull request results in a lot of duplicated code. It would be great if we could fix that. Could you please summarise which FFmpeg options have to be changed to make RTSP work. Thanks. |
|
Hi @bartekpacia, will you have time to resolve these questions, I'd love to see your work merged here :) |
|
Hahah, I totally forgot about this PR. Will look today into it. |
|
Actually what I did in this PR is only apply a patch from @e1z0 that he shared in this issue. I didn't write this code myself. Also, I see that some merge conflicts arose. @tomtastic Feel free to pick up this PR and create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making a PR for changes made by @e1z0 in his issue.
It works really great