Fixes connection leak and endless loop when context error is deadline exceeded (context with timeout) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context error is deadline exceeded.
|
Looks good to me. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran onto an issue where I created repeating cancellable mDNS lookups.
I was using a
context.WithTimeoutto lookup DNS-SD entries but the read loop only checked forcontext.Cancelledwhich resulted in an endless loop when the error function returncontext. DeadlineExceeded.I changed the context check to any error value as the function should always stop regardless of the error reason on the context.
Additionally I noticed that you are not closing the
net.UDPConnused to create thePacketConns op. These are not closed automatically when closing thesePacketConns.This PR will likely close issue #32. It did for us.