Add request tests for core Rails endpoints#45
Draft
roo-code-bruno[bot] wants to merge 1 commit into
Draft
Conversation
Author
|
Actionable issues found. See task:
|
| end | ||
|
|
||
| test "GET / responds successfully" do | ||
| counter = Counter.clicks |
Author
There was a problem hiding this comment.
This pre-creates the clicks row before the request, so the test no longer exercises the controller path that bootstraps the counter from an empty database. A regression where home#index stops initializing that record would still pass here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this solves
The app's core HTTP flows did not have request-level coverage, so regressions in
/,/ping, or/incrementcould slip through without failing the test suite.Why this change was made
This adds a focused request test file that exercises the current route and controller behavior, verifies the
/pingJSON contract, and confirms/incrementredirects home while enqueuingIncrementCounterJoband leaving the counter unchanged until the async job runs.User impact
Changes to the home page route, ping endpoint, or increment action now surface quickly through
bin/rails testinstead of being caught only in manual testing.Interactively review PR in Roomote