fix(ast): preserve positions and fence data through rawHtml reparse - #286
Draft
Princesseuh wants to merge 7 commits into
Draft
Princesseuh wants to merge 7 commits into
Princesseuh wants to merge 7 commits into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Integrate PR #286 with the fix for #322 on current main. Keep serialization and tokenization semantics, associate original nodes with parser handles, and preserve positions only when source associations remain unambiguous. Preserve the source document for MDX static component overrides and UTF-16 offsets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #322.
Changes
optimizeStatic.data.langanddata.metaon surviving original code-fence elements, without attaching fence metadata to user-supplied raw HTML or parser-created formatting clones.Updated against current
main, retaining its SVG/MathML behavior. The previous direct-token feeding approach is replaced with serialization/tokenization so swallowed tags and raw-text contexts keep their existing parsing semantics. Includes separate changesets and updated API/website documentation.Validation
cargo test --allcargo test -p satteri-ast --no-default-features --features from-htmlpnpm lint, all-target Clippy, and formatting checksRegressions cover Markdown/MDX HAST plugin observability and compilation, repeated/lookalike raw HTML, foster-parented fences, swallowed or malformed tags, formatting clones, nested MDX, source positions, UTF-16 offsets, coalesced text, and conservative raw-block spans.