Skip to content

Conversation

@Pooja0504
Copy link
Collaborator

<< Describe the changes >>

Closes:

@Pooja0504 Pooja0504 requested a review from Copilot September 22, 2025 10:06
@Pooja0504 Pooja0504 changed the title AXE-2194 : FR1 - fix false positives fix : AXE-2194 : FR1 - fix false positives Sep 22, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds text comparison functionality to fix false positives in the label content name mismatch check, specifically for AXE-2194 FR1. The changes implement advanced text comparison using stemming and cosine similarity to better match visible text with accessible names.

  • Adds stemming-based text comparison with synonym handling and unicode normalization
  • Introduces inline overflow checking to skip hidden elements in text calculation
  • Enhances text processing options to include whitespace removal

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
package.json Adds wink-porter2-stemmer dependency for text stemming functionality
lib/commons/text/subtree-text.js Adds overflow detection to skip hidden inline elements
lib/commons/text/remove-unicode.js Extends options to support whitespace removal
lib/commons/text/native-text-alternative.js Adds context flag to ignore native text alternatives
lib/checks/label/label-content-name-mismatch-evaluate.js Implements advanced text comparison with stemming and cosine similarity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Pooja0504 Pooja0504 changed the title fix : AXE-2194 : FR1 - fix false positives fix : AXE-2194 - FR1 fix false positives Sep 22, 2025
@Pooja0504 Pooja0504 changed the title fix : AXE-2194 - FR1 fix false positives fix: AXE-2194 - FR1 fix false positives Sep 22, 2025
@Pooja0504 Pooja0504 requested a review from Copilot September 22, 2025 10:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Abhi3685
Abhi3685 previously approved these changes Sep 24, 2025
@mattscepter mattscepter changed the base branch from main to release-5.10.0 October 29, 2025 09:42
@mattscepter mattscepter merged commit c341923 into release-5.10.0 Oct 29, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants