Readable streams can be passed to opts.fileCache #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows stream.Readable instances in
fileCache
. Duck-typing the stream so other allowed types (String/Buffer) will not be affected.Seemed like there is no provided way to persist the cache. I'm using a Proxy's
getOwnPropertyDescriptor
trap (triggered byxhas
) to dynamically populate the cache with asynchronousfs.readFile
calls.Would otherwise suggest having an asynchronous
fileRead
API with a cache lookup callback in the options.