Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'global' instead of window. Fixes #36 #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use 'global' instead of window. Fixes #36 #37

wants to merge 1 commit into from

Conversation

kumavis
Copy link

@kumavis kumavis commented Jan 19, 2014

global is provided by browserify to be window in normal windows or self in workers

Fixes #36

@lawnsea lawnsea mentioned this pull request Jan 20, 2014
Closed
@lawnsea
Copy link

lawnsea commented Jan 31, 2014

Any idea when this one might land? I need this for jsdom/jsdom#711. Is there anything I can do to help move things along?

@kumavis
Copy link
Author

kumavis commented Feb 4, 2014

@lawnsea The monkey-patch is global.window = global at the top of your worker src

lawnsea referenced this pull request in TreehouseJS/jsdom Aug 11, 2014
@lawnsea
Make jsdom browserifiable and add browser test runner
fd2bc1a 
To run the tests: `node test/browser-runner.js`. The runner accepts the same
options as `test/runner`, as well as some optional arguments that control the
test setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for webworkers
2 participants
@kumavis @lawnsea