sign: throw on unsupported padding scheme

[btj]

Do not silently apply the wrong padding scheme. Would have saved me hours of head-scratching and screen-staring.

[ljharb]

awesome, thanks! i'm happy to make the changes i suggested as part of the rebase i'll do once i land another PR that's queued up, and then this can be landed too :-)

[ljharb]

yay, the tests are doing their job :-)

there's some failures, where older node isn't throwing an exception where the tests expect it i think?

[btj]

Actually, it seems that the check of the error message was too strict; I replaced it by a regex.

[ljharb]

the 3 remaining failures seem legitimate

[btj]

First of all, the test messages were wrong: I had swapped 'browser' and 'node'. Old versions of Node.js do not support the padding option and therefore ignore it and never throw. Programs written against old Node versions will not include the padding option and therefore are not affected by the new throw statement in browserify. So I let the test run only for recent Node versions.

[btj]

OK, it turned out the isNode10() function in the test suite is broken: it looks at the minor version instead of the major version. I fixed it so that the test suite now considers the major version.

Interestingly, this means the passphrase tests did run on many of the old Node versions tested, just not on 4.9 and 7.10. And they succeeded! Still, I now disabled these tests for major versions <= 10, as seemed to be intended.

[btj]

I now ran the passphrase tests on 4.9 on my machine, and they run just fine, so it seems better to simply enable them always. People might be depending on them working on old node versions.

[ljharb]

Good catch! Let's switch those checks to use semver (v6), rather than string munging.

[btj]

Weird; I'm unable to reproduce the failure on node 8.0. On my machine, the test suite runs fine on node 8.0.

[ljharb]

It works on node 8 latest, but fails for me on node 8.2, for example.

Support for the padding option was indeed added in 8.0, though, so maybe it was broken until v8.6? i'll update the skip logic.