-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotations for Scrollable elements in a11y-dom hybrid #463
Open
seanmcguire12
wants to merge
18
commits into
main
Choose a base branch
from
a11y-dom-hybrid-scrollable-elems
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+210
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a335bca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ybrid-scrollable-elems # Conflicts: # lib/a11y/utils.ts
seanmcguire12
added
observe
These changes pertain to the observe function
text-extract
These changes pertain to text-extract
labels
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
observe
These changes pertain to the observe function
text-extract
These changes pertain to text-extract
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
observe
callswhat changed
getMainScrollableElement
function inprocess.ts
togetScrollableElements
, which now optionally returns a list of all the scrollable elements on the page unless thetopN
param is specified.processAllOfDom
, we settopN
to1
to maintain the existing behaviour.process.ts
calledgetScrollableElementXpaths
which callsgetScrollableElements
and then callsgenerateXpaths
on each of the returned elements. This function returns a list of xpaths for each scrollable element on the page.getScrollableElementXpaths
globally so that it can be called froma11y/utils.ts
findScrollableElementIds
ina11y/utils.ts
which calls thegetScrollableElementXpaths
function from the browser context, evaluates the returned xpaths, and returns their correspondingbackendDOMId
'sgetAccessibilityTree
to prepend the stringScrollable
to therole
of all the scrollable elements in the a11y treeexample
LLM input before this PR:
LLM input after this PR: