Comprehensive jsnum tests #1818
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t exercised by Pyret
- fromString(): for non-negative-exp sci not, avoid a division
- js-numbers.js returns _innards to allow more testing
- liftFixnumInteger: should produce valid Rational boxnum
- add test for toRepeatingDecimal
- test toStringDigits
- correct isInteger() def
schanzer
reviewed
Sep 22, 2025
tests/jsnums-test/jsnums-test.js
Outdated
| expect(JN.fromString("1e140", sampleErrorBacks)).toEqual(JN.makeBignum("1e140")); | ||
|
|
||
| // for large bignums (> 1e140 ?), fromString() and makeBignum() can give structurally | ||
| // unequal results. so the following fail: |
There was a problem hiding this comment.
@ds26gte why are these commented out? We should be testing to make sure they fail, right?
- ensure integerNthRoot() is monotonically nondecreasing brownplt#1822 - require integerNthRoot() root and radicand to be non-neg - require nthRoot() root to be non-neg
** should remove fields at .t and above ** should remove any trailing zero fields, also reducing .t - bnDivide() should call clamp()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This in-progress PR addresses Issue #1812.
A JS test file
tests/jsnums-test/jsnums-test.cwill test the methods and functions defined injs-numbers.js(Pyret's number library) that cannot be adequately tested by Pyret test files such astests/pyret/tests/test-numbers.js.This PR is WIP, and not ready to merge yet.