Skip to content

Accessibility changes #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dscreve wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Accessibility changes #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9362f93
Make challenge size readable by others
dscreve Nov 6, 2025
b6aca28
Make Challenge generator public
dscreve Nov 6, 2025
56fed32
Add public API
dscreve Nov 6, 2025
256f0e8
Add public attribute
dscreve Nov 6, 2025
a26e4ae
Adujst KeyedDecodingContainer public extension
dscreve Nov 23, 2025
e6a983a
Made requested chanes for this PR
dscreve Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Sources/WebAuthn/Helpers/ChallengeGenerator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,17 @@
//
//===----------------------------------------------------------------------===//

package struct ChallengeGenerator: Sendable {
public struct ChallengeGenerator: Sendable {
static let challengeSize: Int = 32

var generate: @Sendable () -> [UInt8]

package static var live: Self {
.init(generate: { [UInt8].random(count: 32) })
.init(generate: { [UInt8].random(count: challengeSize) })
}

public init(generate: @escaping @Sendable () -> [UInt8]) {
self.generate = generate
}

}
4 changes: 2 additions & 2 deletions Sources/WebAuthn/Helpers/KeyedDecodingContainer+decodeURLEncoded.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import Foundation

extension KeyedDecodingContainer {
func decodeBytesFromURLEncodedBase64(forKey key: KeyedDecodingContainer.Key) throws -> [UInt8] {
public func decodeBytesFromURLEncodedBase64(forKey key: KeyedDecodingContainer.Key) throws -> [UInt8] {
guard let bytes = try decode(
URLEncodedBase64.self,
forKey: key
Expand All @@ -28,7 +28,7 @@ extension KeyedDecodingContainer {
return bytes
}

func decodeBytesFromURLEncodedBase64IfPresent(forKey key: KeyedDecodingContainer.Key) throws -> [UInt8]? {
public func decodeBytesFromURLEncodedBase64IfPresent(forKey key: KeyedDecodingContainer.Key) throws -> [UInt8]? {
guard let bytes = try decodeIfPresent(
URLEncodedBase64.self,
forKey: key
Expand Down
2 changes: 1 addition & 1 deletion Sources/WebAuthn/WebAuthnManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public struct WebAuthnManager: Sendable {
self.init(configuration: configuration, challengeGenerator: .live)
}

package init(configuration: Configuration, challengeGenerator: ChallengeGenerator) {
public init(configuration: Configuration, challengeGenerator: ChallengeGenerator) {
self.configuration = configuration
self.challengeGenerator = challengeGenerator
}
Expand Down