Skip to content

Add ARM64 support to workflow #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brofield merged 7 commits into from
Nov 13, 2025
Merged

Add ARM64 support to workflow #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f416e6
Add ARM64 support to build and test workflow
claude Nov 13, 2025
f5b95f1
Fix ARM64 runner labels for GitHub Actions
claude Nov 13, 2025
ad486b7
Add C++17 requirement for tests target
claude Nov 13, 2025
f2dc333
Improve C++17 configuration using proper CMake properties
claude Nov 13, 2025
f96bc07
Force C++17 standard for GoogleTest via cache variables
claude Nov 13, 2025
4b47e96
Set C++17 directly on GoogleTest targets after creation
claude Nov 13, 2025
d56bf11
Remove macOS 13 from workflow, keep only macOS 14 (ARM64)
claude Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ jobs:
ctest --verbose --test-dir build -C Release

Ubuntu:
runs-on: ubuntu-latest
strategy:
matrix:
runner: [ubuntu-latest, ubuntu-24.04-arm]
runs-on: ${{ matrix.runner }}
steps:
- name: Checkout code
uses: actions/checkout@v5
Expand All @@ -44,7 +47,7 @@ jobs:
ctest --verbose --test-dir build-system-gtest

MacOS:
runs-on: macos-latest
runs-on: macos-14
steps:
- name: Checkout code
uses: actions/checkout@v5
Expand Down
14 changes: 14 additions & 0 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ else()
URL_HASH SHA1=0ac421f2ec11af38b0fff0f1992184032731a8bc
)
FetchContent_MakeAvailable(googletest)

# GoogleTest v1.14.0+ requires C++17
# Set C++ standard on GoogleTest targets to match our tests
set_target_properties(gtest gtest_main PROPERTIES
CXX_STANDARD 17
CXX_STANDARD_REQUIRED ON
CXX_EXTENSIONS OFF
)
endif()

set(TEST_SOURCES
Expand All @@ -29,6 +37,12 @@ endif()

add_executable(tests ${TEST_SOURCES})

set_target_properties(tests PROPERTIES
CXX_STANDARD 17
CXX_STANDARD_REQUIRED ON
CXX_EXTENSIONS OFF
)

add_test(NAME tests COMMAND tests)
target_link_libraries(tests PRIVATE ${PROJECT_NAME} GTest::gtest_main)

Expand Down