Create release 4.23 #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated version numbers in SimpleIni.h and CMakeLists.txt from 4.22 to 4.23 to prepare for new release including all recent changes.
- Added Installation section clarifying SimpleIni is header-only - Added Building and Testing section with CMake instructions - Added instructions for running tests with ctest - Added CMake integration examples for both subdirectory and system-wide installation - Makes it clear that no building is required for library usage
The MacOS GitHub Actions runner was failing because pkg-config couldn't find the googletest installation from Homebrew. Updated tests/Makefile to: - Try pkg-config first (works on Ubuntu) - Fall back to Homebrew prefix on MacOS (brew --prefix) - Fall back to standard /usr/local paths as last resort This makes the build more robust across different platforms and installation methods while maintaining backwards compatibility. Fixes #80
Use formula-specific prefix (brew --prefix googletest) instead of the general Homebrew prefix. This is more reliable on modern Homebrew installations where formulas are installed in versioned directories. Also removed -lpthread flag on MacOS as it's not needed and may cause linking issues.
- Add environment diagnostics to see what's failing - Set PKG_CONFIG_PATH to include Homebrew's googletest - Make make test continue-on-error so CMake tests still run - This will help us see the actual problem and test a fix
The MacOS GitHub Actions runner's pkg-config doesn't automatically find Homebrew-installed packages. Set PKG_CONFIG_PATH to include both the general Homebrew pkgconfig directory and googletest's specific location. This fixes the 'Package gtest_main was not found' error that was causing make builds to fail on MacOS while CMake builds succeeded (CMake has better Homebrew integration). Tested and verified working in run 19322908359.
GoogleTest 1.17.0 (now installed by Homebrew on MacOS) requires C++17 as minimum. Updated from -std=c++14 to -std=c++17 to fix compilation error: 'C++ versions less than C++17 are not supported.' This matches the CMake configuration which already uses C++17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.