CI: no atomic ptr build testing #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brody4hire
force-pushed
the
brody-no-atomic-ptr-build-ci-testing
branch
from
dc87a2d to
caa49d9
Compare
brody4hire
commented
Feb 4, 2025
.github/workflows/build.yml
Outdated
Comment on lines
209
to
215
| # WORKAROUND FIRST BUILD ISSUE FOR NOW | ||
| - run: cargo add once_cell -F critical-section -p rustls | ||
| - run: cargo add portable-atomic -F critical-section -p rustls | ||
|
|
||
| - name: cargo build (debug; no default features; no-std) # no std; no built-in provider; XXX TBD hashbrown - ??? | ||
| run: cargo build --locked --no-default-features --target riscv32imc-unknown-none-elf | ||
| working-directory: rustls |
There was a problem hiding this comment.
now fails as expected - see https://github.com/brody4hire/rustls/actions/runs/13127518610/job/36626561569?pr=6
error[E0433]: failed to resolve: could not find `sync` in `alloc`
--> rustls/src/lib.rs:416:37
|
416 | pub(crate) type Arc<T> = alloc::sync::Arc<T>;
| ^^^^ could not find `sync` in `alloc`
|
note: found an item that was configured out
--> /rustc/f027438f8bc6b747528dca8b8de1304[35](https://github.com/brody4hire/rustls/actions/runs/13127518610/job/36626561569?pr=6#step:6:36)44d7238/library/alloc/src/lib.rs:246:9
note: the item is gated here
--> /rustc/f0274[38](https://github.com/brody4hire/rustls/actions/runs/13127518610/job/36626561569?pr=6#step:6:39)f8bc6b747528dca8b8de13043544d7238/library/alloc/src/lib.rs:245:1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arcdue to missing atomic ptr functionality on this test target - want to ensure this will test that usingportable_atomic_util::Arcwill resolve this issue