starting portable-rustls fork with doc TODOs - more updates than expected as needed for testing, CI & initial doc updates (Brody personal CI testing)
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brody4hire
changed the title
portable-rustls fork (Brody personal CI testing) with doc TODOs - more updates than expected as needed to fix tests, CI jobs, and initial doc updates
brody4hire
changed the title
portable-rustls fork (Brody personal CI testing) with doc TODOs - more updates than expected as needed to fix tests, CI jobs, and initial doc updatesportable-rustls fork with doc TODOs - more updates than expected as needed to fix tests, CI jobs, and initial doc updates - Brody personal CI testing
brody4hire
changed the title
portable-rustls fork with doc TODOs - more updates than expected as needed to fix tests, CI jobs, and initial doc updates - Brody personal CI testingportable-rustls fork with doc TODOs - more updates than expected as needed to fix tests, CI jobs, and initial doc updates (Brody personal CI testing)
brody4hire
force-pushed
the
brody-start-portable-rustls-fork-ci-testing
branch
9 times, most recently
from
bb5a823 to
d5e1c4d
Compare
brody4hire
changed the title
portable-rustls fork with doc TODOs - more updates than expected as needed to fix tests, CI jobs, and initial doc updates (Brody personal CI testing)portable-rustls fork with doc TODOs - more updates than expected as needed for testing, CI & initial doc updates (Brody personal CI testing)
brody4hire
force-pushed
the
brody-start-portable-rustls-fork-ci-testing
branch
2 times, most recently
from
b4ea7ce to
a12a599
Compare
brody4hire
force-pushed
the
brody-start-portable-rustls-fork-ci-testing
branch
from
a12a599 to
af6b8c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
general context:
I would like to start a new
portable-rustlsfork (which I have already reserved the crate name for) to support targets with no atomic ptr, as requested in rustls#2068 to unblock esp-rs/esp-hal#1836. I Brody proposed a solution in rustls#2200, but it was rejected due to the requirements for both Rust nightly & an unstable cfg flag.The new solution we agreed upon is to add & use a top-level
sync::Arc, which a fork can more easily adapt to use anotherArcimplementation such asportable-atomic-util::Arcto support embedded targets with no atomic ptr. I have made this update in rustls#2285; next step is for someone to start & support a new fork to support these embedded targets.