Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XXX CAPTURE PR 2200 BUILD & CI TODO ITEMS THAT MAY BE DEFERRED #1

Draft
wants to merge 54 commits into
base: main
Choose a base branch
from
Draft

XXX CAPTURE PR 2200 BUILD & CI TODO ITEMS THAT MAY BE DEFERRED #1

wants to merge 54 commits into from

Conversation

brody4hire
Copy link
Owner

@brody4hire brody4hire commented Nov 27, 2024 •
edited
Loading

@brody4hire brody4hire self-assigned this Nov 27, 2024
@brody4hire
specify once_cell features only in rustls/Cargo.toml; update related …
d12db3f 
…comments
@brody4hire
remove outdated XXX / TODO ITEMS for critical-section option
2aa9084
@brody4hire
add XXX / TODO comment for aws-lc-rs alias
5fbd1b1
@brody4hire
update comment re: once_cell
bb485b3
@brody4hire
fix cargo config for portable-atomic & portable-atomic-util
afaa20c
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
4e37375 
…-atomic-arc-option
@brody4hire
Revert "add XXX / TODO comment for aws-lc-rs alias"
61e9ad4 
This reverts commit 5fbd1b1.
@brody4hire
remove XXX cargo comments not needed for critical-section feature
a136ee3
@brody4hire
further update to ccritical-section feature documentation
dc6fd11
@brody4hire
remove a meaningless XXX / TODO comment from CI build config
98a6dcf
@brody4hire
update provider example to support optional critical-section feature
f0a0b4d
@brody4hire
fixup CI re: update provider example to support optional critical-sec…
b6bfe1a 
…tion feature
@brody4hire
CI: build rustls-provider-example with all features including critica…
2010e1d 
…l-section feature - XXX TODO NEED TO RESOLVE KNOWN BUILD ISSUE
@brody4hire
add & update XXX / TODO comments in provider example
976d2ea
@brody4hire
resolve issue with ARC in: provider-example/src/hpke.rs
b1ebb9a
@brody4hire
CI cross build rustls-provider-example - XXX TODO BUILD FAILURE on ta…
f927c49 
…rget with no atomic ptr is expected
@brody4hire
revert recent updates to provider example for now, at least
dca23a4
@brody4hire
resolve CI XXX: TODO ADD RATIONALE ... ...
bb7c01d
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
cd74a46 
…-atomic-arc-option
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
0d4e032 
…-atomic-arc-option
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
cf76510 
…-atomic-arc-option
@brody4hire
XXX SKIP COVERAGE CI JOB FOR NOW - XXX TODO INVESTIGATE / FIX / RE-EN…
e6a2568 
…ABLE
@brody4hire
fixup! XXX SKIP COVERAGE CI JOB FOR NOW - XXX TODO INVESTIGATE / FIX …
bbdad2e 
…/ RE-ENABLE
@brody4hire
re-enable CI coverage job - should be OK now (hopefully)
e538bb3
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
1c47efb 
…-atomic-arc-option
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
f516bdf 
…-atomic-arc-option
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
c7c1fd8 
…-atomic-arc-option
@brody4hire
add pub util module to export Arc alias with XXX TODO ITEMS
fac3a09
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
d7e49b9 
…-atomic-arc-option
@brody4hire
update provider-example to support critical-section option (with CI t…
fc88c56 
…esting)
@brody4hire
FIXUP CI JOB RE: update provider-example to support critical-section …
b6bceb1 
…option (with CI testing)
@brody4hire
update comment for [package.metadata.docs.rs] in rustls/Cargo.toml
4eb4ff0
@brody4hire
finish replacing rustls::internal::alias::Arc -> rustls::util::alias:…
e4a8c77 
…:Arc
@brody4hire
update exported Arc type alias (seems to fix generated doc links to A…
b6aeea8 
…rc); add quick doc comments; do pub(crate) use for internal Arc alias
@brody4hire
testing provider example with critical-section feature - see if this …
d59a774 
…works & if PR coverage issue goes away
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
f2a8b2c 
…-atomic-arc-option
@brody4hire
fixup! testing provider example with critical-section feature - see i…
d777159 
…f this works & if PR coverage issue goes away
@brody4hire
XXX SKIP CI CLIPPY JOBS FOR NOW - XXX TODO INVESTIGATE / FIX / RE-ENABLE
bd2ed25
@brody4hire
update coverage CI task to include unit test of rustls-provider-examp…
d05eda4 
…le - XXX TODO THIS UPDATE SHOULD COME FROM SEPARATE PR
@brody4hire
re-enable CI clippy jobs with workaround, see if it works now
e68a623
@brody4hire
reword comments in admin/clippy
cedc301
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
ccaec19 
…-atomic-arc-option
@brody4hire
fixup provider example testing in CI config - [hopefully] fixes CI bu…
c4f0cfd 
…ild issue
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
08a727d 
…-atomic-arc-option
@brody4hire
introduce admin/all-stable-features - see if this works in GitHub CI
fd33928
@brody4hire
remove blank line from imports in: rustls/tests/server_cert_verifier.…
a23a446 
…rs before merging updates from main
@brody4hire
Merge branch 'main' of https://github.com/rustls/rustls into portable…
d3070ca 
…-atomic-arc-option
@brody4hire
remove extra space added to CI build YML
e37ed57
@brody4hire
fix & re-enable CI cargo package step
c9f0247
@brody4hire
add & update some documentation with XXX / TODO ITEMS
f9c71cd
@brody4hire
remove remaining XXX TBD consider CI testing of more items with `crit…
5a27c6d 
…ical-section` feature - @brodycj opinion is that these items only need to be tested with non-unstable features
@brody4hire
remove XXX TODO test release comments from CI - test with release is …
cf63047 
…only needed with fips - looks like some other items are tested without --locked flag
@brody4hire
benchmarks CI updates - micro-benchmarks for "all stable features"; r…
ffaaa94 
…emove XXX comments no longer needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brody4hire brody4hire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brody4hire