[WIP TBD ...] test cleanup: simpler mock of prompts [...] #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brody4hire
changed the title
brody4hire
pushed a commit
that referenced
this pull request
Mar 1, 2020
(internal prompt helper function) and update test snapshots ref:pr #25
brody4hire
pushed a commit
that referenced
this pull request
Mar 1, 2020
* cleanup: use prompt helper for Android package id (internal prompt helper function) and update test snapshots ref:pr #25 * check prompts argument is an Array in test mocks
brody4hire
changed the title
with TBD comments to simplify snapshots
brody4hire
force-pushed
the
use-internal-prompt-helper-for-android-package-id
branch
from
d162f07 to
2301fb3
Compare
brody4hire
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATED: cleanup of prompts usage was done in a different PR, this PR is now limited to the test cleanup.
with
additional testcleanup to simplify the mock of prompts✅
npm testis okTODO items:
remove a test workaround that was done to avoid extra snapshot churnupdate test snapshots to be consistent with simpler mock of prompts