Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] [BREAKING] mandatory default package identifier for Android #156

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brody4hire
Copy link
Owner

@brody4hire brody4hire commented Sep 22, 2019

with blank default package identifier

followup item for PR #153 - add native item with package ID to package.json

Note that this proposal is using back-ticks instead of single quotes. I think this is a little more proper for templating in general.

TODO items:

  • fix Android package identifier description text (PR fix Android package identifier description text #155)
  • test CLI with this update
  • update test suite using Stryker Mutator to help ensure no loss of test coverage
  • start using back ticks through the rest of the code (and tracking this update), maybe with some help from the eslint tool

with blank default package identifier
@brody4hire brody4hire self-assigned this Sep 22, 2019
@brody4hire brody4hire changed the title mandatory default package identifier for Android [RFC] [BREAKING] mandatory default package identifier for Android Nov 15, 2019
@brody4hire brody4hire changed the base branch from dev to master November 15, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant