[DDO-3469] Thelma refactoring: remove state.Destinations() interface
#251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed image: us-central1-docker.pkg.dev/dsp-artifact-registry/thelma/thelma:v1.1.26-d8651f3 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 55.96% 55.90% -0.06%
==========================================
Files 194 193 -1
Lines 13282 13253 -29
==========================================
- Hits 7433 7409 -24
+ Misses 5201 5198 -3
+ Partials 648 646 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Pushed image: us-central1-docker.pkg.dev/dsp-artifact-registry/thelma/thelma:v1.1.26-19618cf |
|
Pushed image: us-central1-docker.pkg.dev/dsp-artifact-registry/thelma/thelma:v1.1.26-b0a9260 |
em-may
approved these changes
Feb 7, 2024
choover-broad
force-pushed
the
ch-DDO-3469-update-outputs
branch
from
07ba79e to
1d83e5f
Compare
|
Pushed image: us-central1-docker.pkg.dev/dsp-artifact-registry/thelma/thelma:v1.1.27-587c63e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knock another bullet off of step 1 in the fix thelma state doc.
Changes
terra.Destinationsinterface and update its lone caller to call.Environments()and.Clusters()separatelyTesting
This is pure refactoring; the existing test coverage is sufficient to test these changes.