ID-816 New Orch User Registration Flow #196
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed image: us-central1-docker.pkg.dev/dsp-artifact-registry/thelma/thelma:v1.0.100-40c9544 |
choover-broad
approved these changes
Nov 21, 2023
| "Hogwarts", "dsde", | ||
| "Cambridge", "MA", "USA", | ||
| "Remus Lupin", "Non-Profit") | ||
| if err = opts.handleErrorWithForce(err); err != nil { |
There was a problem hiding this comment.
keep this error check :)
|
Pushed image: us-central1-docker.pkg.dev/dsp-artifact-registry/thelma/thelma:v1.0.100-69ad458 |
|
Pushed image: us-central1-docker.pkg.dev/dsp-artifact-registry/thelma/thelma:v1.0.100-8fe1094 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 54.91% 54.98% +0.06%
==========================================
Files 176 176
Lines 8234 8233 -1
==========================================
+ Hits 4522 4527 +5
+ Misses 3125 3119 -6
Partials 587 587
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Pushed image: us-central1-docker.pkg.dev/dsp-artifact-registry/thelma/thelma:v1.0.100-f354db1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/ID-816
Orch now has an endpoint that both registers a user and accepts the terms of service in one go. Thelma should use it!