Sz add mem disk aligned metrics #448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonn-smith
requested changes
Apr 23, 2024
|
|
||
| String? gcs_output_dir | ||
|
|
||
| Int? mem_gb_input_ReadMetrics # Optional input for memory in GiB |
There was a problem hiding this comment.
Actually, it might be better to define the inputs as the struct for runtime attributes. Then you can just bubble that whole struct down.
RuntimeAttr? runtime_attr_override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented enhancements to the
ReadMetricstask, allowing for customizable memory inputs and adding support for SSD. This update will provide better flexibility for allocating memory to thePerFlowCellMetricstask.The modifications have been successfully tested on Terra.