update Dockerfile and Makefile for Canu version update. add parameter in Canu.wdl. #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SHuang-Broad
requested changes
Mar 29, 2023
| TAG2 = us.gcr.io/broad-dsp-lrma/$(IMAGE_NAME):latest | ||
| VERSION = 0.2.0 | ||
|
|
||
| TAG1 = us.gcr.io/broad-dsp-lrma/lr-canu:$(VERSION) |
There was a problem hiding this comment.
Need to revert back to the old way.
|
|
||
| build_no_cache: | ||
| docker build --no-cache -t $(TAG1) -t $(TAG2) . | ||
| docker build -t $(TAG1) -t $(TAG2) . |
There was a problem hiding this comment.
check tabs and spaces
| set -euxo pipefail | ||
| canu -correct \ | ||
| canu -correct corOutCoverage=~{corrected_coverage}\ |
There was a problem hiding this comment.
add space at then end of the line
| canu -correct corOutCoverage=~{corrected_coverage}\ | ||
| -p ~{prefix} -d canu_correct_output \ | ||
| genomeSize=~{genome_size}m \ | ||
| genomeSize=~{genome_size}k \ |
There was a problem hiding this comment.
rename the variable to genome_sz_in_kb
| canu -trim \ | ||
| -p ~{prefix} -d canu_trim_output \ | ||
| genomeSize=~{genome_size}m \ | ||
| genomeSize=~{genome_size}k \ |
| canu -assemble \ | ||
| -p ~{prefix} -d canu_assemble_output \ | ||
| genomeSize=~{genome_size}m \ | ||
| genomeSize=~{genome_size}k \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated Dockerfile and Makefile for Canu2.2 version update.
added "technology" parameter in Canu.wdl to specify nanopore vs pacbio sequencing method