add per_workflow_cost_cap arg #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheiman
requested changes
Mar 20, 2025
|
@dheiman Sorry, should've pinged you as well as re-requesting review. I think this is ready to merge? |
dheiman
requested changes
Apr 8, 2025
firecloud/fiss.py
Outdated
| 'this amount. See Cromwell docs ' + | ||
| '(https://cromwell.readthedocs.io/en/develop/cromwell_features/RetryWithMoreMemory)' + | ||
| ' for more information.') | ||
| subp.add_argument('-p', '--per_workflow_cost_cap', type=float, |
There was a problem hiding this comment.
Suggested change
| subp.add_argument('-p', '--per_workflow_cost_cap', type=float, | |
| subp.add_argument('-P', '--per_workflow_cost_cap', type=float, |
-p is reserved for project name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding the new cost cap argument. I haven't bumped the version number or updated release notes in case folks at DSP want to wait on this PR until the feature is out of beta.