Skip to content

skipping tests for rgp while experiments are underway for a domain change #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions playwright-e2e/.eslintignore

This file was deleted.

4 changes: 3 additions & 1 deletion playwright-e2e/dsm/component/dropdown.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ export default class Dropdown {
}

async open(): Promise<void> {
!(await this.isOpen()) && (await this.toLocator.locator('a.dropdown-toggle').click());
if (!(await this.isOpen())) {
(await this.toLocator.locator('a.dropdown-toggle').click());
}
}

async selectOption(value: string): Promise<void> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@ export class CustomizeView {

private async selectOrDeselect(columnName: string, deselect = false): Promise<void> {
const checkbox = this.columnCheckbox(columnName);
deselect ? await checkbox.uncheck() : await checkbox.check();
if (deselect) {
await checkbox.uncheck();
} else {
await checkbox.check();
}
}

private async openColumnsGroup(opts: { nth?: number } = {}): Promise<void> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ export class Search {

public async open(): Promise<void> {
const open = await this.isOpen();
!open && await this.page.locator(this.openButtonXPath).click();
if (!open) {
await this.page.locator(this.openButtonXPath).click();
}
await expect(async () => expect(await this.isOpen()).toBe(true)).toPass({ timeout: 5000 });
}

Expand Down
5 changes: 1 addition & 4 deletions playwright-e2e/dsm/enums.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export enum CustomizeView {
COHORT_TAGS = 'Cohort Tags Columns',
CONTACT_INFORMATION = 'Contact Information Columns',
DIAGNOSIS_TYPE = 'Survey: Your Child\'s/Your [DIAGNOSIS TYPE] Columns',
DSM_COLUMNS = 'Participant - DSM Columns',
GENOME_STUDY = 'Genome Study Columns',
GRANDPARENT = 'Grandparent Columns',
HALF_SIBLING = 'Half-Sibling Columns',
Expand Down Expand Up @@ -84,7 +83,6 @@ export enum CustomizeView {
export enum CustomizeViewID {
ABSTRACTION = 'a',
ADD_CHILD_PARTICIPANT = 'ADD_PARTICIPANT',
ADULT_CONSENT = 'CONSENT',
ATCP_DSM_REGISTRATION_MISCELLANEOUS = 'AT_GROUP_MISCELLANEOUS',
ATCP_DSS_REGISTRATION = 'REGISTRATION',
ATCP_PARTICIPANT_INFO = 'AT_PARTICIPANT_INFO',
Expand Down Expand Up @@ -423,7 +421,6 @@ export enum Label {
GENDER = 'Gender',
GENDER_IDENTITY = 'GENDER_IDENTITY',
GERMLINE_CONSENT_COMPLETED = 'GERMLINE_CONSENT_ADDENDUM Survey Completed',
GERMLINE_CONSENT_CREATED = 'GERMLINE_CONSENT_ADDENDUM Survey Created',
GERMLINE_CONSENT_LAST_UPDATED = 'GERMLINE_CONSENT_ADDENDUM Survey Last Updated',
GERMLINE_SURVEY_STATUS = 'GERMLINE_CONSENT_ADDENDUM Survey Status',
GERMLINE_CONSENT_KID_COMPLETED = 'GERMLINE_CONSENT_ADDENDUM_PEDIATRIC Survey Completed',
Expand Down Expand Up @@ -646,7 +643,7 @@ export enum Label {
SPECIALITY_PROJECT_CAGI_2022 = 'Speciality Project: CAGI 2022',
SPECIALITY_PROJECT_CAGI_2023 = 'Speciality Project: CAGI 2023',
SPECIALITY_PROJECT_CZI = 'Speciality Project: CZI',
SPECIALITY_PROJECT_R21 = 'Speciality Project: CZI',
SPECIALITY_PROJECT_R21 = 'Speciality Project: R21',
STATUS = 'Status',
STATE = 'State',
STREET_ONE = 'Street 1',
Expand Down
1 change: 1 addition & 0 deletions playwright-e2e/dss/component/input.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export default class Input extends WidgetBase {
} = {}): Promise<void> {
const { dropdownOption, type, nth, waitForSaveRequest = false, overwrite = false } = opts;
const useType = type ? type : false;
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
nth ? this.nth = nth : this.nth;

const doAfterFill = async (): Promise<void> => {
Expand Down
174 changes: 174 additions & 0 deletions playwright-e2e/eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,174 @@
import { defineConfig, globalIgnores } from 'eslint/config';
import typescriptEslint from '@typescript-eslint/eslint-plugin';
import _import from 'eslint-plugin-import';
import { fixupPluginRules } from '@eslint/compat';
import globals from 'globals';
import tsParser from '@typescript-eslint/parser';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import js from '@eslint/js';
import { FlatCompat } from '@eslint/eslintrc';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const compat = new FlatCompat({
baseDirectory: __dirname,
recommendedConfig: js.configs.recommended,
allConfig: js.configs.all
});

export default defineConfig([globalIgnores([
'**/tests-examples',
'**/.eslintrc.js',
'**/node_modules/',
'**/build/',
'**/playwright-report/',
'**/test-results/',
'**/html-test-results/',
]), {
extends: compat.extends('eslint:recommended', 'plugin:@typescript-eslint/recommended'),

plugins: {
'@typescript-eslint': typescriptEslint,
import: fixupPluginRules(_import),
},

languageOptions: {
globals: {
...globals.node,
},

parser: tsParser,
ecmaVersion: 'latest',
sourceType: 'module',

parserOptions: {
projectService: {
allowDefaultProject: [
'*.js',
'*.mjs'
],
}
},
},

rules: {
curly: 'warn',
eqeqeq: ['warn', 'smart'],
'no-unused-vars': 'off',

'@typescript-eslint/no-unused-vars': ['off', {
argsIgnorePattern: '_',
args: 'none',
}],

'@typescript-eslint/no-unused-vars-experimental': 'off',
'no-multi-spaces': 'warn',
'array-bracket-newline': ['warn', 'consistent'],
'array-bracket-spacing': 'warn',
'block-spacing': 'warn',
'@typescript-eslint/no-unused-expressions': ['warn', {
allowShortCircuit: true,
allowTernary: true
}],

'brace-style': ['warn', '1tbs', {
allowSingleLine: true,
}],

camelcase: ['warn', {
properties: 'never',
}],

'comma-spacing': 'warn',
'comma-style': 'warn',
'computed-property-spacing': 'warn',
'eol-last': 'warn',
'func-call-spacing': 'warn',
'implicit-arrow-linebreak': 'warn',
'key-spacing': 'warn',
'keyword-spacing': 'warn',

'lines-between-class-members': ['warn', 'always', {
exceptAfterSingleLine: true,
}],

'no-floating-decimal': 'warn',
'no-lonely-if': 'warn',
'no-multi-assign': 'warn',
'no-multiple-empty-lines': 'warn',
'no-trailing-spaces': 'warn',
'no-unneeded-ternary': 'warn',
'no-whitespace-before-property': 'warn',
'nonblock-statement-body-position': 'warn',

'object-curly-newline': ['warn', {
multiline: true,
consistent: true,
}],

'one-var': ['warn', 'never'],
'padded-blocks': ['warn', 'never'],
'quote-props': ['warn', 'as-needed'],

quotes: ['warn', 'single', {
allowTemplateLiterals: true,
avoidEscape: true,
}],

'space-before-blocks': 'warn',

'space-before-function-paren': ['warn', {
anonymous: 'never',
named: 'never',
asyncArrow: 'always',
}],

'space-in-parens': 'warn',
'space-infix-ops': 'warn',
'arrow-spacing': 'warn',
'no-useless-rename': 'warn',
'no-var': 'warn',
'object-shorthand': 'warn',
'prefer-arrow-callback': 'warn',
'prefer-const': 'warn',
'prefer-template': 'warn',
'prefer-rest-params': 'warn',
'prefer-spread': 'warn',
'rest-spread-spacing': 'warn',
'template-curly-spacing': 'warn',
'vars-on-top': 'warn',
'comma-dangle': 'off',
'@typescript-eslint/comma-dangle': 'off',
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-floating-promises': 'error',
'@typescript-eslint/require-await': 'error',
'@typescript-eslint/await-thenable': 'error',
'@typescript-eslint/no-misused-promises': 'error',
'@typescript-eslint/promise-function-async': 'error',
'import/first': 'warn',

'import/no-anonymous-default-export': ['warn', {
allowObject: true,
}],

'no-debugger': 'warn',

'no-restricted-imports': ['error', {
patterns: [{
group: ['../'],
message: 'Relative import is not allowed.',
}],
}],

'@typescript-eslint/no-non-null-assertion': 'off',

'max-len': ['warn', 150, {
ignorePattern: '^import |^export\\{(.*?)\\}',
ignoreComments: true,
ignoreUrls: true,
tabWidth: 2,
ignoreRegExpLiterals: true,
}],
},
}]);
Loading