-
Notifications
You must be signed in to change notification settings - Fork 1
Add AnnData API widget tests #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cornhundred
wants to merge
33
commits into
main
Choose a base branch
from
codex/add-unit-tests-for-anndata-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* manually bringing in parquet processing * big int * fixing bug with parquet matrix processing * fix index parsing bug * removed print and console logs * added mat as kwarg * Update src/celldega/viz/widget.py Co-authored-by: Copilot <[email protected]> * Update js/read_parquet/network_from_parquet.js Co-authored-by: Copilot <[email protected]> * implemnting astype change --------- Co-authored-by: Copilot <[email protected]>
more efficient hash for sparse data Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new unit test to verify that the Landscape widget can be initialized with an AnnData object and correctly exposes parquet-encoded metadata and UMAP outputs.
- Introduce
make_simple_anndata
helper to generate a minimal AnnData instance. - Add
test_landscape_initializes_with_anndata
to check the widget’smeta_cell_parquet
,meta_cluster_parquet
, andumap_parquet
outputs.
Comments suppressed due to low confidence (1)
tests/unit/test_viz/test_landscape_anndata.py:31
- The keyword argument
AnnData
likely does not match the widget’s expected parameter name (e.g.,adata
). Update this to the correct argument to ensure the widget initializes without errors.
widget = Landscape(base_url="https://example.com", AnnData=adata)
Base automatically changed from
DEGA-68-parquet-for-Landscape-traitlet-data-transfer
to
main
July 17, 2025 20:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AnnData
objectTesting
npm test
(fails: jest not found)pytest
(fails: pytest-cov missing)https://chatgpt.com/codex/tasks/task_b_68780f224ffc832a908de69217fd1383