Skip to content

Conversation

cornhundred
Copy link
Collaborator

Summary

  • update shader injection syntax for CustomBitmapLayer
  • adjust CustomMatrixLayer draw method for deck.gl v9 opts
  • re-enable EditableGeoJsonLayer integration

Testing

  • npm test (fails: jest not found)
  • pytest (fails: unrecognized arguments)

https://chatgpt.com/codex/tasks/task_b_686934ab2904832aa1b6154f97cdfcd8

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates several custom Deck.gl layers for compatibility with deck.gl v9 and re-enables the editable GeoJSON layer integration.

  • Adjusts the draw method signature in CustomMatrixLayer to accept full options and merge uniforms.
  • Updates shader injection syntax in CustomBitmapLayer to the v9 style.
  • Restores and refactors edit_layer.js, re-enabling EditableGeoJsonLayer and related utilities.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
js/deck-gl/matrix/custom_matrix_layer.js Changed draw({uniforms}) to draw(opts) and merged opts into the super call
js/deck-gl/layers/edit_layer.js Un-commented and refactored the editable GeoJSON layer setup, added import and utility functions
js/deck-gl/layers/CustomBitmapLayer.js Updated shader injection keys to new v9 syntax for DECKGL_FILTER_COLOR
Comments suppressed due to low confidence (2)

js/deck-gl/layers/edit_layer.js:205

  • The function name 'update_edit_visitility' contains a typo; consider renaming it to 'update_edit_visibility' for clarity.
export const update_edit_visitility = (layers_obj, visible) => {

js/deck-gl/layers/edit_layer.js:10

  • The import path appears to have a typo: 'layers_ist' should likely be 'layers_list' to match the utility filename.
import { get_layers_list } from '../utils/layers_ist';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant