feat: Update CMake to use PkgConfig for Lua discovery #31
+18
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the CMake build system to leverage PkgConfig for locating Lua libraries and headers, improving compatibility and simplifying the build process. - Removed the custom cmake/Modules/FindLua5X.cmake module. - Updated CMakeLists.txt to use find_package(PkgConfig) and pkg_check_modules(LUA REQUIRED lua). - Changed CMAKE_MINIMUM_REQUIRED to version 3.10. - Replaced INCLUDE_DIRECTORIES with TARGET_INCLUDE_DIRECTORIES for cmod_ev. - Modified lua_ev.c, lua_ev.h, obj_lua_ev.c, and watcher_lua_ev.c to make version, traceback, obj_index, and push_objs functions non-static, allowing them to be properly linked and used after the CMake changes. - Adjusted assertions in watcher_lua_ev.c for clarity and consistency. Fixes: brimworks#24 Signed-off-by: Matěj Cepl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the CMake build system to leverage PkgConfig for locating Lua libraries and headers, improving compatibility and simplifying the build process.
Fixes: #24