Skip to content

feat: Add Perfetto trace to VideoHoleDraw #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-bashir-bs merged 2 commits into from
Mar 9, 2026
Merged

feat: Add Perfetto trace to VideoHoleDraw #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e85209
feat: Add Perfetto trace to VideoHoleDraw
t-bashir-bs Feb 24, 2026
8ac1458
Merge branch '28-x-y-bs' into tbashir/28-x-y-bs-add-perfetto-trace-to…
t-bashir-bs Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions patches/chromium/.patches
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,4 +200,5 @@ add_mse_support_to_brightsign_video_player_os-19598.patch
feat_enable_hls_support_when_brightsign_media_player_is_enabled.patch
feat_add_video_audio-codecs-supported_flag_support.patch
brightsign_enable_viewport_options_when_viewport_enabled_os-20339.patch
feat_add_perfetto_trace_to_videoholedraw.patch
feat_enable_cross-process_memory_pressure_notification_on_all.patch
38 changes: 38 additions & 0 deletions patches/chromium/feat_add_perfetto_trace_to_videoholedraw.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Tariq Bashir <[email protected]>
Date: Tue, 24 Feb 2026 09:41:28 +0000
Subject: feat: Add Perfetto trace to VideoHoleDraw

Add Perfetto trace event to the VideoHoleDraw function in the OverlayStrategyUnderlayBrightsign class.
This will help in debugging and performance analysis of video overlay rendering on BrightSign devices.

diff --git a/components/viz/service/display/overlay_strategy_underlay_brightsign.cc b/components/viz/service/display/overlay_strategy_underlay_brightsign.cc
index bda69e19a679cbedf35e0fc2b6cf7440a5d38369..214c781a0b44bf5ae065fe2b7db16a6b1cddb0b1 100644
--- a/components/viz/service/display/overlay_strategy_underlay_brightsign.cc
+++ b/components/viz/service/display/overlay_strategy_underlay_brightsign.cc
@@ -9,6 +9,7 @@
#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/threading/platform_thread.h"
+#include "base/trace_event/trace_event.h"
#include "base/unguessable_token.h"
#include "build/chromecast_buildflags.h"
#include "components/viz/common/quads/aggregated_render_pass_draw_quad.h"
@@ -119,7 +120,16 @@ bool OverlayStrategyUnderlayBrightsign::VideoHoleDraw(
std::string overlay_plane_id = VideoHoleDrawQuad::MaterialCast(*quad)->overlay_plane_id.ToString();
std::string factory_name = VideoHoleDrawQuad::MaterialCast(*quad)->factory_name;

-
+ TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("viz.debug.overlay_planes"),
+ "OverlayStrategyUnderlayBrightsign::VideoHoleDraw",
+ "info",
+ base::StringPrintf("%s: %dx%d @ %d,%d clip:%dx%d @ %d,%d, opacity:%f",
+ factory_name.c_str(),
+ b_display_rect.width, b_display_rect.height,
+ b_display_rect.x, b_display_rect.y,
+ b_clip_rect.width, b_clip_rect.height,
+ b_clip_rect.x, b_clip_rect.y,
+ quad->shared_quad_state->opacity * opacity));
vid_player_set_geometry(factory_name.c_str(), overlay_plane_id.c_str(),
b_display_rect, b_clip_rect);
vid_player_set_opacity(factory_name.c_str(), overlay_plane_id.c_str(),