Skip to content

feat: Enable viewport options when viewport-enabled OS-20339 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-bashir-bs merged 1 commit into from
Feb 23, 2026
Merged

feat: Enable viewport options when viewport-enabled OS-20339 #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions patches/chromium/.patches
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,3 +200,4 @@ fix_wayland_window_call_setwindowgeometry_for_position_updates.patch
add_mse_support_to_brightsign_video_player_os-19598.patch
feat_enable_hls_support_when_brightsign_media_player_is_enabled.patch
feat_add_video_audio-codecs-supported_flag_support.patch
brightsign_enable_viewport_options_when_viewport_enabled_os-20339.patch
27 changes: 27 additions & 0 deletions patches/chromium/brightsign_enable_viewport_options_when_viewport_enabled_os-20339.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Tariq Bashir <[email protected]>
Date: Wed, 18 Feb 2026 09:45:57 +0000
Subject: Brightsign: Enable viewport options when viewport enabled OS-20339

This patch enables the viewport options when the viewport is enabled, and matches
what is done in QtWebEngine. This is necessary to match Android defaults and ensure
that the viewport behaves as expected.

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index e49ccf4ffc115a78abceeddd7f452aeeb5c6a917..213720fb0f5ba536aaa6527e9edea9a0efd4e547 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3089,6 +3089,13 @@ const blink::web_pref::WebPreferences WebContentsImpl::ComputeWebPreferences() {
#endif
}

+ if (prefs.viewport_enabled) {
+ // We need to enable the viewport options together as it doesn't really work
+ // to enable them separately. With viewport-enabled we match Android defaults.
+ prefs.viewport_meta_enabled = true;
+ prefs.shrinks_viewport_contents_to_fit = true;
+ }
+
prefs.spatial_navigation_enabled =
command_line.HasSwitch(switches::kEnableSpatialNavigation);