Skip to content

feat: Enable hls mimetype support OS-20673 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caneraltinbasak merged 1 commit into from
Jan 30, 2026
Merged

feat: Enable hls mimetype support OS-20673 #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions patches/chromium/.patches
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,3 +198,4 @@ ozone_nexus_implement_setfullscreen_for_nexuswindow_os-19899.patch
enable_memory_pressure_monitoring_and_enable_for_renderer_process.patch
fix_wayland_window_call_setwindowgeometry_for_position_updates.patch
add_mse_support_to_brightsign_video_player_os-19598.patch
feat_enable_hls_support_when_brightsign_media_player_is_enabled.patch
55 changes: 55 additions & 0 deletions patches/chromium/feat_enable_hls_support_when_brightsign_media_player_is_enabled.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Caner Altinbasak <[email protected]>
Date: Fri, 30 Jan 2026 12:14:33 +0000
Subject: feat: Enable HLS support when Brightsign media player is enabled
OS-20673

Brightsign media player can play HLS streams, enable mimetype support
to enable Youtube live streams through HLS

diff --git a/media/base/BUILD.gn b/media/base/BUILD.gn
index 0a4e2c55b6e298996107376dc110aee5e1d63fc4..89c8d6c964f044c55454ac2acb82938da5cd8150 100644
--- a/media/base/BUILD.gn
+++ b/media/base/BUILD.gn
@@ -416,6 +416,10 @@ source_set("base") {
deps += [ "//third_party/libvpx" ]
}

+ if (enable_brightsign_media_player) {
+ defines = ["ENABLE_BRIGHTSIGN_MEDIA_PLAYER"]
+ }
+
if (is_linux && !is_castos) {
sources += [ "user_input_monitor_linux.cc" ]
} else if (is_mac) {
diff --git a/media/base/mime_util_internal.cc b/media/base/mime_util_internal.cc
index b2d6ca38c4aefad37d6260f796a931ee7b303d5c..a46a2d93bb1f2850f55c19ead847f9374d17d69e 100644
--- a/media/base/mime_util_internal.cc
+++ b/media/base/mime_util_internal.cc
@@ -407,6 +407,26 @@ void MimeUtil::AddSupportedMediaFormats() {
video_3gpp_codecs.emplace(H264);
AddContainerWithCodecs("video/3gpp", video_3gpp_codecs);

+#if defined(ENABLE_BRIGHTSIGN_MEDIA_PLAYER)
+ bool is_brightsign_player = base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseBrightsignMediaPlayer);
+ if (is_brightsign_player) {
+ CodecSet hls_codecs{H264,
+ // TODO(ddorwin): Is any MP3 codec string variant
+ // included in real queries?
+ MP3,
+ // Android HLS only supports MPEG4_AAC (missing demuxer
+ // support for MPEG2_AAC)
+ MPEG4_AAC};
+ AddContainerWithCodecs("application/x-mpegurl", hls_codecs);
+ AddContainerWithCodecs("application/vnd.apple.mpegurl", hls_codecs);
+ AddContainerWithCodecs("audio/mpegurl", hls_codecs);
+ // Not documented by Apple, but unfortunately used extensively by Apple and
+ // others for both audio-only and audio+video playlists. See
+ // https://crbug.com/675552 for details and examples.
+ AddContainerWithCodecs("audio/x-mpegurl", hls_codecs);
+ }
+#endif
+
#if BUILDFLAG(IS_ANDROID)
if (base::FeatureList::IsEnabled(kCanPlayHls)) {
// HTTP Live Streaming (HLS).