feat: Add MSE support for series 3 & 4 devices OS-19598#111
Merged
t-bashir-bs merged 1 commit into28-x-y-bsfrom Dec 16, 2025
Merged
feat: Add MSE support for series 3 & 4 devices OS-19598#111t-bashir-bs merged 1 commit into28-x-y-bsfrom
t-bashir-bs merged 1 commit into28-x-y-bsfrom
Conversation
t-bashir-bs
force-pushed
the
tbashir/28-x-y-bs-add-mse-support-OS-19598
branch
from
33a5dc0 to
db2f3d9
Compare
t-bashir-bs
force-pushed
the
tbashir/28-x-y-bs-add-mse-support-OS-19598
branch
from
db2f3d9 to
43d7d83
Compare
caneraltinbasak
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds support for Media Source Extensions (MSE) to the Brightsign video player in Chromium. The changes have been ported from the implementation made for QtWebEngine for Brightsign devices.
PumpData:
Calls are made to ChunkDemuxerStream::Read when the demuxer is not initialized yet, in the older Chromium this was just ignored with NOTREACHED, but in the newer version NOTREACHED_NORETURN gets called which
crashes the renderer. We now check if the demuxer is initialized before calling ChunkDemuxerStream::Read.
OnDemuxInitialized:
The first_party_url was used in Chromium 87 but in Chromium 120 we don't have
this and so like non-mse playback use the representative_url with the top_frame_origin.
Verified using:
Checklist
npm testpassesRelease Notes
Notes: