Merge pull request #11 from jclusso/add_gh_workflow

Add GH workflow and fix failing items

.github/workflows/tests.yml

@@ -0,0 +1,32 @@
+name: Tests
+
+on:
+  pull_request:
+    branches:
+      - "*"
+  push:
+    branches:
+      - master
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby_version: [2.7.7, 3.0.5, 3.1.3, 3.2.0, 3.3.0]
+        bridgetown_version: [1.2.0]
+    continue-on-error: ${{ endsWith(matrix.ruby, 'head') || matrix.ruby == 'debug' }}
+    # Has to be top level to cache properly
+    env:
+      BUNDLE_JOBS: 3
+      BUNDLE_PATH: "vendor/bundle"
+      BRIDGETOWN_VERSION: ${{ matrix.bridgetown_version }}
+    steps:
+      - uses: actions/checkout@master
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+          bundler-cache: true
+      - name: Test with Rake
+        run: script/cibuild

Gemfile

@@ -5,3 +5,8 @@ source "https://rubygems.org"
 gemspec
 
 gem "bridgetown", ENV["BRIDGETOWN_VERSION"] if ENV["BRIDGETOWN_VERSION"]
+gem "bundler", ">= 1.15"
+gem "html-proofer", "~> 3.7"
+gem "rake", "~> 13.0"
+gem "rspec", "~> 3.5"
+gem "rubocop-bridgetown", "~> 0.3"

bridgetown-seo-tag.gemspec

@@ -17,11 +17,5 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "bridgetown", ">= 1.2.0.beta5", "< 2.0"
-
-  spec.add_development_dependency "bundler", ">= 1.15"
-  spec.add_development_dependency "html-proofer", "~> 3.7"
-  spec.add_development_dependency "rake", "~> 13.0"
-  spec.add_development_dependency "rspec", "~> 3.5"
-  spec.add_development_dependency "rubocop-bridgetown", "~> 0.3"
   spec.metadata["rubygems_mfa_required"] = "true"
 end

lib/bridgetown-seo-tag/url_helper.rb

@@ -12,7 +12,7 @@ module UrlHelper
       # Retruns false if it's a relative URL
       # Returns nil if it is not a string or can't be parsed as a URL
       def absolute_url?(string)
-        return unless string
+        return false unless string
 
         Addressable::URI.parse(string).absolute?
       rescue Addressable::URI::InvalidURIError

spec/bridgetown_seo_tag_integration_spec.rb

@@ -290,6 +290,7 @@
 
       it "minifies the output" do
         version = Bridgetown::SeoTag::VERSION
+        # rubocop:disable Bridgetown/HTMLEscapedHeredoc
         expected = <<~HTML
           <!-- Begin Bridgetown SEO tag v#{version} -->
           <title>Foo</title>
@@ -299,6 +300,7 @@
           <meta property="og:url" content="http://example.invalid/page/" />
           <meta property="og:site_name" content="Foo" />
         HTML
+        # rubocop:enable Bridgetown/HTMLEscapedHeredoc
         expect(output).to match(expected)
       end
     end