added new functionality #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2022 10:14
…_log_to_cloudwatch` - hardening iam - writing to our log groups only - all data resources moved into data.tf - adding missing description for outputs and roles - regenerated README - simplified `ssm_role` IAM role - general cleanup and consolidation - unified IAM polices -> terraform format - fixed access logs being written to the session bucket instead of access log bucket (target_bucket = aws_s3_bucket.access_logs_bucket[0].id) bridgecrewio#15 - unify naming - `access_log_bucket_name` -> `access_logs_bucket_name` (`access_log_bucket` was not in use anyway )
…""` -> always return empty string - simplification of `session_manager_prefs` `aws_ssm_document` - use bool values directly - added new variables/module options to better cover SSM preferences : `bucket_key_prefix`, `idle_session_timeout`, `max_session_duration`, `run_as_default_user`, `enable_run_as` - added new outputs: `iam_policy_arn`, `document_name`, `document_arn` - regenerated `README.md`
|
Any chance these fixes could be approved please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding new functions after code cleanup (#20)
var.linux_shell_profile == "" ? var.linux_shell_profile : ""-> always return empty stringsession_manager_prefsaws_ssm_document- use bool values directlybucket_key_prefix,idle_session_timeout,max_session_duration,run_as_default_user,enable_run_asiam_policy_arn,document_name,document_arnREADME.md