Merge pull request #57 from bricks-cloud/redact-bug

fix bug where regex redaction is run even when there isn't a match
bricks-cloud · May 9, 2024 · 8534708 · 8534708
2 parents 9de7e3e + 281ef2d
commit 8534708
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/internal/policy/policy.go b/internal/policy/policy.go
@@ -744,11 +744,13 @@ func (p *Policy) scan(input []string, scanner Scanner, cd CustomPolicyDetector,
 						continue
 					}
 
-					if sr.Action != Block && sr.Action != AllowButWarn {
-						sr.Action = AllowButRedact
-					}
+					if regex.MatchString(text) {
+						replaced = regex.ReplaceAllString(text, "***")
 
-					replaced = regex.ReplaceAllString(text, "***")
+						if sr.Action != Block && sr.Action != AllowButWarn {
+							sr.Action = AllowButRedact
+						}
+					}
 				}
 			}