Add generate_export_header to be able compile with -DBUILD_SHARED_LIBS=ON #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
generate_export_header(QtAES EXPORT_MACRO_NAME QTAESSHARED_EXPORT)
was removed in commit 93020ab.This causes issues when compiling the project with the
-DBUILD_SHARED_LIBS=ON
CMake flag. We use Qt-AES in Amazfish piggz/harbour-amazfish#520, and we are trying to package it for Alpine Linux, which requires-DBUILD_SHARED_LIBS=ON
to be enabled for such packages.I wasn’t able to find an explanation for why it was removed.
It seems to have been either only partially removed or removed by mistake.
The
generate_export_header
macro generates the qtaes_export.h file, which is included here:Qt-AES/qaesencryption.h
Line 5 in e55c81b
I have added it back to CMake. The other option would be to remove the #include in qaesencryption.h.
Fixes: #68