Open
Conversation
fyellow
approved these changes
Jan 14, 2026
fyellow
left a comment
There was a problem hiding this comment.
Good work! You have finished all the requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UofT-DSI | LCR - Assignment 2
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I updated the assignment code to correctly implement a multivariable linear regression model. This included splitting the dataset into training and testing sets, fitting the model using all numeric predictors, generating predictions on the test set, and evaluating model performance using RMSPE.
What did you learn from the changes you have made?
Through these changes, I learned how important it is to clearly separate predictors and response variables when working with machine learning models. I also gained a better understanding of how to interpret regression coefficients, including why negative coefficients and intercepts are not necessarily errors. Additionally, I learned how RMSPE is calculated and how implementation details can vary depending on library versions.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I considered standardizing the predictor variables and encoding categorical features, but decided against it to stay aligned with the scope of the assignment and focus on core linear regression concepts.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
One challenge was debugging errors caused by passing incorrect objects into the prediction and evaluation functions. I resolved this by carefully tracing variable usage and ensuring consistent data structures. Another challenge was a compatibility issue with the mean_squared_error() function, which I addressed by manually computing the square root of the mean squared error.
How were these changes tested?
I tested the changes by examining the fitted model’s coefficients, verifying that predictions ran successfully on the test set, and confirming that the RMSPE value was reasonable and non-negative. I also checked data dimensions and reproducibility using a fixed random state.
A reference to a related issue in your repository (if applicable)
N/A
Checklist