Skip to content

Fix enum display in index example#123

Open
mtraeger wants to merge 5 commits intobrianchirls:developfrom
mtraeger:develop
Open

Fix enum display in index example#123
mtraeger wants to merge 5 commits intobrianchirls:developfrom
mtraeger:develop

Conversation

@mtraeger
Copy link

This should fix not shown enums in the index.html example in drop down menus.

@brianchirls
Copy link
Owner

Thanks for submitting this. Generally looks good, but a few style nitpicks:

  1. Please declare singleOption as part of the var statement at the top of the function with the rest of the variables. (I may reconsider this style choice in the future, especially if I migrate to ES6 let and const. But I'd like to keep it consistent for now.)

  2. Please do a hasOwnProperty check inside the for...in loop?

  3. option.value = singleOption; is repeated unnecessarily. It can be placed once outside the if branch.

Thanks,
B

@brianchirls brianchirls added the Bug label Jul 2, 2016
@mtraeger
Copy link
Author

mtraeger commented Jul 4, 2016

Thanks for the feedback. I hopefully interpreted 2) correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants