Include job ID in LinkedFileOutput.file_url()
#118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the file URL generation to include the job ID in the URL path, ensuring consistency between file storage paths and their corresponding URLs.
- Moves job ID handling from the file writing logic to both URL generation and S3 object naming
- Ensures that files stored with job ID prefixes have matching URLs that include the job ID
- Maintains backward compatibility for cases where no job ID is present
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+85
to
87
| if self.job_id: | ||
| object_name += f"/{self.job_id}" | ||
| object_name += f"/{filename}" |
There was a problem hiding this comment.
The job_id is being appended to object_name after it's already constructed from the base path. This could result in double slashes or inconsistent path formatting. Consider building the complete object path more systematically, similar to how it's done in the file_url() method.
stefanorosanelli
changed the title
LinkedFileOutput.file_url()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the file URL generation in
LinkedFileOutputfile_url()method to include the job ID in the URL path, ensuring consistency between file storage paths and their corresponding URLs.