Add new /jobs endpoint
#111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new /jobs endpoint to list and filter asynchronous jobs, adds shared date‐filtering utilities, and expands test coverage for both the jobs API and underlying get_jobs logic.
- Added
JobsFilter,get_jobs, andget_jobs_queryfor filtering and paginating async jobs inbrevia/async_jobs.py. - Introduced
date_filterinbrevia/utilities/dates.pyand refactored chat‐history code to use it. - Exposed the
/jobslisting endpoint inbrevia/routers/jobs_router.pyand added comprehensive tests intests/test_async_jobs.pyandtests/routers/test_jobs_router.py.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_async_jobs.py | Added tests for get_jobs covering filters and pagination |
| tests/routers/test_jobs_router.py | Added API tests for the new /jobs endpoint |
| brevia/utilities/dates.py | New date_filter utility for parsing min/max dates |
| brevia/routers/jobs_router.py | Registered /jobs route with dependency and filtering |
| brevia/chat_history.py | Removed duplicate date logic and now uses date_filter |
| brevia/async_jobs.py | Implemented JobsFilter, get_jobs, and query builder |
Comments suppressed due to low confidence (2)
brevia/utilities/dates.py:14
- The docstring line "If None 'min' is i" seems incomplete or contains a typo. Consider rephrasing to: "If no type_str is provided, 'min' is used by default."
Valid values are 'max' or 'min'. If None 'min' is i
brevia/async_jobs.py:82
- SQLAlchemy uses the
isnot()method rather thanis_not(). This line will fail at runtime—change it toAsyncJobsStore.completed.isnot(None).
AsyncJobsStore.completed.is_not(None)
BuonDavide
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
/jobsendpoint to list and filter asynchronous jobsJobsFilter,get_jobs, andget_jobs_queryfor filtering and paginating async jobs inbrevia/async_jobs.py.date_filterinbrevia/utilities/dates.pyand refactored chat‐history code to use it./jobslisting endpoint inbrevia/routers/jobs_router.pyand added comprehensive tests intests/test_async_jobs.pyandtests/routers/test_jobs_router.py