Skip to content

Fix(BREV-2215): Shadeform | Could not find refID error | when manually created instance has no tags #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aditsharma55 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(BREV-2215): Shadeform | Could not find refID error | when manually created instance has no tags #70

aditsharma55 wants to merge 1 commit into from

Conversation

@aditsharma55
Copy link

@aditsharma55 aditsharma55 commented Dec 19, 2025 •
edited
Loading

  1. Modified ListInstances to skip instances without refID tags.
  2. Changed error return to continue statement in the conversion loop, allowing the function to gracefully skip manually-created instances instead of crashing the entire listing operation.
  3. Preserved GetInstance error behavior for manual instances - Kept the halt-and-error behavior when fetching a specific instance by ID that lacks refID tags.

@aditsharma55 aditsharma55 requested a review from a team as a code owner December 19, 2025 13:14
@harshsharmanv harshsharmanv changed the title Fix(BREV-2215): missing refid for shadeform Fix(BREV-2215): Shadeform | Could not find refID error | when manually created instance has no tags Dec 19, 2025
patelspratik
patelspratik reviewed Dec 19, 2025
View reviewed changes
v1/providers/shadeform/instance.go
singleInstance, err := c.convertShadeformInstanceToV1Instance(instance)
if err != nil {
return nil, errors.WrapAndTrace(err)
continue
Copy link
Contributor

@patelspratik patelspratik Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we would want an warn or err log line here so we can track these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patelspratik patelspratik patelspratik approved these changes

Assignees

@aditsharma55 aditsharma55

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aditsharma55 @patelspratik