Skip to content

fix crash on windows #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andriniaina wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix crash on windows #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5496a60
fix crash on windows
andriniaina Mar 7, 2018
ebff686
prublish as a new npm package (waiting for Pull Request approval)
andriniaina Mar 7, 2018
9fb6bfa
change repo.url
andriniaina Mar 7, 2018
03545e0
add myself as contributor ;)
andriniaina Mar 7, 2018
90e1575
bump version
andriniaina Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
> This utility is **exactly** the same as [breser/git2consul](https://github.com/breser/git2consul) but it includes a small patch that fixes a crash on Windows.

# git2consul

[![Build Status](https://travis-ci.org/breser/git2consul.svg?branch=master)](https://travis-ci.org/breser/git2consul)
Expand Down
3 changes: 2 additions & 1 deletion lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ module.exports.validate_writeable_directory = function(dir) {
}

// Check whether this owner or group or anyone is allowed to write the directory.
var can_write = ((process.getuid() === stat.uid) && (stat.mode & 00200)) || // User is owner and owner can write.
var can_write = (!process.getuid) || // process.getuid() does not exist on windows
((process.getuid() === stat.uid) && (stat.mode & 00200)) || // User is owner and owner can write.
((process.getgid() === stat.gid) && (stat.mode & 00020)) || // User is in group and group can write.
((stat.mode & 00002)); // Anyone can write.
if (!can_write) {
Expand Down
10 changes: 7 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
{
"name": "git2consul",
"name": "git2consul-windows",
"description": "System for moving data from git to consul",
"license": "Apache-2.0",
"version": "0.12.13",
"version": "0.12.14",
"contributors": [
{
"name": "Ryan Breen",
"email": "[email protected]"
},
{
"name": "Andri Rakotomalala",
"email": "[email protected]"
}
],
"repository": {
"type": "git",
"url": "git://github.com/Cimpress-MCP/git2consul.git"
"url": "git://github.com/andriniaina/git2consul-windows.git"
},
"dependencies": {
"body-parser": "~1.4.3",
Expand Down