Skip to content

Retrying connection to consul to avoid purge if consul is not available #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samifruit514 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Retrying connection to consul to avoid purge if consul is not available #143

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ce45a6
Retrying connection to consul to avoid purge if consul is not available
Mar 21, 2017
a0179e7
removing err check that is not reachable.
Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/consul/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,16 @@ var process_records = function(branch, records, cb) {
exports.getLastProcessedRef = function(branch, cb) {
var key_name = create_key_name(branch, branch.name + '.ref', true);
consul.kv.get({'key': key_name, token: token}, function(err, item) {
if(err) {
logger.warn('Cannot connect to consul to get the last processed reference id. Retrying...');
setTimeout(
function() {
exports.getLastProcessedRef(branch,cb);
},5000
);
// end this "thread"
return;
}
/* istanbul ignore if */
if (err) return cb(err);
Copy link

@guylain guylain Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is useless and should be removed as there should not be an err at this point.

cb(null, item === undefined ? item : item.Value);
Expand Down