Skip to content

fix: 🐛 improve accessibility #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gabrielbsb21 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: 🐛 improve accessibility #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a6846c
fix: 🐛 improve accessibility
Gabrielbsb21 Nov 28, 2022
885ce82
Merge branch 'main' into improve-accessibility
flaviojmendes Feb 3, 2023
8e71331
Merge branch 'main' into improve-accessibility
Gabrielbsb21 May 7, 2023
59617c6
Merge branch 'main' into improve-accessibility
flaviojmendes May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="en">
<html lang="pt-br">
<head>
<meta charset="utf-8" />
<meta property="og:title" content="BR Dev Streamers" />
Expand Down
2 changes: 1 addition & 1 deletion public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="en">
<html lang="pt-br">
<head>
<meta charset="utf-8" />
<meta property="og:title" content="BR Dev Streamers" />
Expand Down
2 changes: 1 addition & 1 deletion src/components/layouts/LandingLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default function LandingLayout({ children }: Props) {
return (
<Stack>
<Header />
<Box m={[0, "center"]}>
<Box m={[0, "center"]} as="main">
<Container maxW="container.xl" mb="10">
{children}
</Container>
Expand Down
5 changes: 3 additions & 2 deletions src/components/sections/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@ import { Box, Text, Link } from "@chakra-ui/react";

export default function Footer() {
return (
<Box>
<Box maxW={"container.xl"} m={"0 auto"}>
<Box as="footer">
<Box maxW={"container.xl"} m={"0 auto"} as="section">
<Box
py={4}
m={4}
borderTopColor={"whiteAlpha.100"}
borderTopWidth={1}
textAlign={"end"}
as="article"
>
<Text color="primary.400" fontSize={"sm"}>
Idealizado por{" "}
Expand Down
166 changes: 92 additions & 74 deletions src/components/sections/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import {
Spacer,
Text,
Button,
List,
ListItem,
Link as ChakraLink,
useMediaQuery,
useDisclosure,
Expand Down Expand Up @@ -52,7 +54,7 @@ export default function Header() {

return (
<>
<Flex p={4} borderBottomColor={"whiteAlpha.100"} borderBottomWidth={1} alignItems="center">
<Flex p={4} borderBottomColor={"whiteAlpha.100"} borderBottomWidth={1} alignItems="center" as="header">
<Link to="/">
<HStack>
<Image src="/logo.svg" alt="Br Dev Streamers" height={50} width={50} />
Expand All @@ -67,42 +69,52 @@ export default function Header() {
<Spacer />
{isLargerThanLg && (
<>
<HStack gap={4}>
{links.map((link) => (
<Link
to={link.to}
key={link.id}
<HStack gap={4} as="nav">
<List display="flex" gap={4}>
{links.map((link) => (
<ListItem key={link.id}>
<Link
to={link.to}

color={"gray.100"}
_activeLink={{
color: "primary.500",
}}
_hover={{ textDecoration: "underline" }}
data-test="header-link"
>
{link.label}
</Link>
</ListItem>
))}
</List>
</HStack>
<Spacer />
<HStack gap={4} as="nav">
<List display="flex" gap={4}>
<ListItem>
<ChakraLink
isExternal={true}
href={"https://github.com/brdevstreamers"}
color={"gray.100"}
_activeLink={{
color: "primary.500",
}}
_hover={{ textDecoration: "underline" }}
data-test="header-link"
>
{link.label}
</Link>
))}
</HStack>
<Spacer />
<HStack gap={4}>
<ChakraLink
isExternal={true}
href={"https://github.com/brdevstreamers"}
color={"gray.100"}
_hover={{ textDecoration: "underline" }}
data-test="header-link"
>
GitHub
</ChakraLink>
<ChakraLink
isExternal={true}
href={"https://discord.gg/collabcode"}
color={"gray.100"}
_hover={{ textDecoration: "underline" }}
data-test="header-link"
>
Discord
</ChakraLink>
GitHub
</ChakraLink>
</ListItem>
<ListItem>
<ChakraLink
isExternal={true}
href={"https://discord.gg/collabcode"}
color={"gray.100"}
_hover={{ textDecoration: "underline" }}
data-test="header-link"
>
Discord
</ChakraLink>
</ListItem>
</List>
{/* <Button
bgColor={"primary.500"}
borderRadius={"sm"}
Expand Down Expand Up @@ -136,50 +148,56 @@ export default function Header() {
<DrawerOverlay />

<DrawerContent bgColor="secondary.600" color="gray.100" px={4} pt={16}>
<DrawerCloseButton />
<DrawerCloseButton aria-label="Fechar" />

<VStack alignItems="start">
{links.map((link) => (
<Link
to={link.to}
key={link.id}
w="full"
p={2}
rounded="sm"
color={"gray.100"}
_activeLink={{
color: "primary.500",
bgColor: "blackAlpha.500",
}}
_hover={{ bgColor: "blackAlpha.500" }}
>
{link.label}
</Link>
))}

<ChakraLink
isExternal={true}
href={"https://github.com/brdevstreamers"}
color={"gray.100"}
w="full"
p={2}
rounded="sm"
_hover={{ bgColor: "blackAlpha.500" }}
>
GitHub
</ChakraLink>
<List display="flex" flexDirection="column" gap={4} width="100%">
{links.map((link) => (
<ListItem key={link.id} display="flex">
<Link
to={link.to}
w="full"
p={2}
rounded="sm"
color={"gray.100"}
_activeLink={{
color: "primary.500",
bgColor: "blackAlpha.500",
}}
_hover={{ bgColor: "blackAlpha.500" }}
>
{link.label}
</Link>
</ListItem>
))}

<ChakraLink
isExternal={true}
href={"https://discord.gg/collabcode"}
p={2}
w="full"
rounded="sm"
color={"gray.100"}
_hover={{ bgColor: "blackAlpha.500" }}
>
Discord
</ChakraLink>
<ListItem display="flex">
<ChakraLink
isExternal={true}
href={"https://github.com/brdevstreamers"}
color={"gray.100"}
w="full"
p={2}
rounded="sm"
_hover={{ bgColor: "blackAlpha.500" }}
>
GitHub
</ChakraLink>
</ListItem>
<ListItem display="flex">
<ChakraLink
isExternal={true}
href={"https://discord.gg/collabcode"}
p={2}
w="full"
rounded="sm"
color={"gray.100"}
_hover={{ bgColor: "blackAlpha.500" }}
>
Discord
</ChakraLink>
</ListItem>
</List>
</VStack>
</DrawerContent>
</Drawer>
Expand Down
3 changes: 2 additions & 1 deletion src/components/sections/SkeletonListCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {

export const SkeletonListCard = () => {
return (
<SimpleGrid minChildWidth="300px" columns={{ sm: 2, md: 3, lg: 4 }} gap={4}>
<SimpleGrid minChildWidth="300px" columns={{ sm: 2, md: 3, lg: 4 }} gap={4} as="section">
{[...new Array(8)].map((_el, index) => (
<Box
key={index}
Expand All @@ -23,6 +23,7 @@ export const SkeletonListCard = () => {
overflowY="clip"
textOverflow="ellipsis"
bgColor="whiteAlpha.100"
as="article"
>
<Stack>
<Skeleton height="167px" />
Expand Down
2 changes: 2 additions & 0 deletions src/pages/About.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import LandingLayout from "../components/layouts/LandingLayout";
export default function About() {
return (
<LandingLayout>
<Box as="section">
<Box mt={8} mb={4}>
<Heading>Sobre</Heading>
<Text color={"gray.500"}>Saiba mais sobre o projeto!</Text>
Expand Down Expand Up @@ -133,6 +134,7 @@ export default function About() {
</AccordionPanel>
</AccordionItem>
</Accordion>
</Box>
</LandingLayout>
);
}