fix: add support for Mercosul motorcycle license plates#458
Merged
Conversation
Member
|
@Henrique-volponi thanks! just fix the tests please!! |
Contributor
Author
|
Done! I've fixed the formatting issues (tabs vs spaces) and cleaned up the test comments. The CI should pass now. Thanks! |
hyanmandian
approved these changes
Mar 30, 2026
Member
|
Thanks for the contribution @Henrique-volponi ! I already published 2.0.1 with this change and added you in our contributor list! Let me know if its now working as expected 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: support motorcycle plates in mercosul validation
The
mercosulRegexwas only validating car plates (e.g.ABC1D23),rejecting valid motorcycle plates (e.g.
ABC12D3). This fix updatesthe regex to cover both formats.
Supported formats
ABC1D23[a-z]{3}[0-9]{1}[a-z]{1}[0-9]{2}ABC12D3[a-z]{3}[0-9]{2}[a-z]{1}[0-9]{1}Changes
mercosulRegexinis-valid-license-plate.tsto match both patternsis-valid-license-plate.test.ts