Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add base command object #16

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[WIP] Add base command object #16

wants to merge 1 commit into from

Conversation

ailecksandr
Copy link
Member

@ailecksandr ailecksandr commented Apr 10, 2018 •
edited
Loading

Such as we had met ActiveInteraction as very messy, we decided to provide own base command object

  • Test if all works correctly on 2-3 level of nesting after inheritance from Commando::Base;
  • Find better workaround for controller params passed into method as arguments;
  • Provide test coverage for written code

@ailecksandr ailecksandr self-assigned this Apr 10, 2018
@ailecksandr ailecksandr changed the base branch from master to dev April 10, 2018 16:20
ailecksandr
ailecksandr commented Mar 13, 2019
View reviewed changes
app/facades/articles/index_facade.rb
def articles
@articles ||= FindAndOrder
.call(ids
.result
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewr224 andrewr224 Awaiting requested review from andrewr224

@MatskoVolodia MatskoVolodia Awaiting requested review from MatskoVolodia

Assignees

@ailecksandr ailecksandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ailecksandr